Generate JVM default methods for procedural interfaces #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelCourtney
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
skovati
approved these changes
Oct 10, 2024
JoelCourtney
force-pushed
the
feat/generate-default-methods-on-jvm
branch
from
7ba3ffd to
7526fe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some reason Kotlin doesn't automatically generate JVM interface default methods by default, and you have to enable it with a compiler flag. In a few interfaces, I've provided a couple default overload specializations of a method (i.e.
plan.directives()anddirectives(type)delegate todirectives(type, deserializer)). If you implement the interface in Kotlin, you don't have to override the overloads. But in Java you do, unless we have this flag.Verification
I tested this by converting the
NotImplementedPlantest stub from Kotlin to Java.