Delete procedural remote package #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelCourtney
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
mattdailis
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR delete the contents of the procedural/remote package and comments out the publishing block. I think these interfaces will be helpful in the future, but for now they are dead weight and probably ought to be reimplemented anyway.
Verification
I had to delete TimelineRemoteTests.java in the e2e tests, which is kinda useful, but I could bring it back later when I recreate it in graphql.
Documentation
Future work
After procedural constraints is out, I can republish the package and recreate them in graphql.