Support events emitted from daemon tasks #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweaks the handling of event provenance to account for events emitted from daemon tasks to avoid NullPointerException. All credit to @mattdailis for this fix.
mattdailis
force-pushed
the
bugfix/events-from-daemons
branch
from
94381b1 to
3f4bf36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tweaks the handling of event provenance to account for events emitted from daemon tasks to avoid NullPointerException.
All credit to @mattdailis for this fix.
Verification
I did some manual testing with a local Aerie instance, on a model that used the streamline Logger to emit events from daemon tasks, and verified that the simulation completes without error and the events appear in the simulation events table in the UI.
Documentation
N/A - bug fix
Future work
N/A