GH workflow to publish images for PRs labeled 'publish' #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandelany
added
ci
dandelany
added
publish
dandelany
changed the title
dandelany
requested review from
mattdailis,
JoelCourtney and
skovati
and removed request for
mattdailis
|
In order to test the |
skovati
reviewed
Aug 28, 2024
|
The PR isn't actually blocked on the failure, it's blocked on a lack of an approval. The reason it isn't blocked is because the |
dandelany
force-pushed
the
feature/publish-pr-branch-workflow
branch
from
46b989b to
1811bed
Compare
Done! will do the same for the other 2 PRs. |
Mythicaeda
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting this issue: #1538
This change will cause the GH "Publish" workflow to run whenever an
aeriePR is given the "publish" label, which will cause Docker images to be published from the PR branch, tagged with the PR number eg.pr-1540The published aerie PR can then be referenced in an
aerie-uiPR with a flag in the PR body that looks like eg.___REQUIRES_AERIE_PR___="1540", which will cause theaerie-uie2e tests to use the publishedpr-1540aerie images during testing rather than the defaultdevelopbranch.