Stateless Aerie - Simulation #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mythicaeda
force-pushed
the
feat/headless-aerie
branch
from
a85e0fa to
dd76d59
Compare
Mythicaeda
force-pushed
the
feat/headless-aerie
branch
from
dd76d59 to
dd01c9e
Compare
goetzrrGit
approved these changes
Aug 22, 2024
merlin-sdk/src/main/java/gov/nasa/jpl/aerie/merlin/protocol/types/Duration.java
Show resolved
Hide resolved
...ss-aerie/src/main/java/gov/nasa/jpl/aerie/stateless/simulation/SimulationExtentConsumer.java
Outdated
Show resolved
Hide resolved
...ess-aerie/src/main/java/gov/nasa/jpl/aerie/stateless/simulation/SimulationResultsWriter.java
Outdated
Show resolved
Hide resolved
Mythicaeda
force-pushed
the
feat/headless-aerie
branch
from
dd01c9e to
fa97b7c
Compare
Mythicaeda
force-pushed
the
feat/headless-aerie
branch
from
fa97b7c to
8b62d91
Compare
Co-authored-by: Ryan Goetz <[email protected]>
- Add new Plan Constructor with Sim Config Co-authored-by: Ryan Goetz <[email protected]>
- Make Duration.isEqualTo null-safe
Mythicaeda
force-pushed
the
feat/headless-aerie
branch
from
8b62d91 to
ef6a569
Compare
Co-authored-by: Ryan Goetz <[email protected]>
Co-authored-by: Ryan Goetz <[email protected]>
- Remove Extent in favor of SimResults.duration Co-authored-by: Ryan Goetz <[email protected]>
- Uses deprecated SecurityManager -- see comment on class for more details - Created as the CLI calls `System.exit()` under certain conditions (such as displaying help text for a subcommand). This allows those conditions to be tested.
* Verify that the generated temporary filename conforms to file naming conventions and remove any invalid characters
With the changes made, a Plan now contains all of the information necessary to simulate. Additionally, since this class will be more relevant to external users via the Orchestration package, comment and privatize fields. Additionally, prevent the sim config and activity directive maps from being null. Co-authored-by: Ryan Goetz <[email protected]>
- reduces the codebase of the system users of orchestration-utils need to depend on - avoids code duplication
Mythicaeda
force-pushed
the
feat/headless-aerie
branch
from
ef6a569 to
db45aca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds three packages:
orchestration: package containing classes useful for orchestrating aerie (ie, calling simulation, loading a mission model)stateless-aerie: package containing a Java CLI that runs aerie in a stateless mode (compared to the Python CLI, which runs against a venue)type-utils: package containing types commonly used by various parts of the system (ie Plan, MissionModelId). Created as a first step towards not requiring so many parts of the system to import other packages in order to use common types: iemerlin_driver. @mattdailis I'd like your thoughts on this package's existence/contents.Verification
Unit tests were added that the orchestration works as expected. Reference JSONs of simulation results for tests were manually validated.
Documentation
Docs need to be created for the new JSON schemas: Sim Configs, Sim Results.
Future work
Integration with Procedural Scheduling.
Further work to extract more common types into
type-utilsand common parsers into aparsing-utils-type package.