Use MissionModelId Class instead of String #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change done now as we expect users of the Orchestration Library to be referencing our Plan class Co-authored-by: Ryan Goetz <[email protected]>
Mythicaeda
added
breaking change
Mythicaeda
added a commit
that referenced
this pull request
Aug 16, 2024
Change done now as we expect users of the Orchestration Library to be referencing our Plan class Co-authored-by: Ryan Goetz <[email protected]>
Mythicaeda
added a commit
that referenced
this pull request
Aug 20, 2024
Change done now as we expect users of the Orchestration Library to be referencing our Plan class Co-authored-by: Ryan Goetz <[email protected]>
goetzrrGit
approved these changes
Aug 21, 2024
Mythicaeda
added a commit
that referenced
this pull request
Aug 21, 2024
Change done now as we expect users of the Orchestration Library to be referencing our Plan class Co-authored-by: Ryan Goetz <[email protected]>
|
👍 looked at this with @Mythicaeda on a call also, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Frontend PR.
Updates the Merlin part of the codebase to use a numerical MissionModelId record instead of a raw String to represent model ids. This makes it consistent with the rest of the codebase and the database.
Breaking change as this replaces the
ID!inactions.graphqlwithInt!. This change may impact users of the following actions:getModelEffectiveArgumentsgetActivityEffectiveArgumentsBulkconstraintsDslTypescriptvalidateActivityArgumentsvalidateModelArgumentsUsers will be impacted only if they were using a query variable for the
missionModelIdargument of these actions. If they were, this can be fixed by changing the type of that query variable fromID!toInt!Two deprecated actions have also been impacted.
getActivityEffectiveArgumentsandresourceTypes. UsegetActivityEffectiveArgumentsBulkin place ofgetActivityEffectiveArguments. Query theresource_typetable in place of theresourceTypesaction.Verification
Unit tests were updated to reflect the change in type.
Documentation
Docs PR
Future work