Include the Sim Error Activity Type Stack trace #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetzrrGit
force-pushed
the
feature/sim_error_stacktrace
branch
from
521edac to
37aebe9
Compare
goetzrrGit
force-pushed
the
feature/sim_error_stacktrace
branch
from
37aebe9 to
cf31286
Compare
goetzrrGit
force-pushed
the
feature/sim_error_stacktrace
branch
from
cf31286 to
9393185
Compare
Mythicaeda
reviewed
Jul 25, 2024
merlin-driver/src/main/java/gov/nasa/jpl/aerie/merlin/driver/SimulationDriver.java
Outdated
Show resolved
Hide resolved
merlin-driver/src/main/java/gov/nasa/jpl/aerie/merlin/driver/engine/SimulationEngine.java
Outdated
Show resolved
Hide resolved
goetzrrGit
force-pushed
the
feature/sim_error_stacktrace
branch
from
9393185 to
f3e4ed3
Compare
* Added effected activity type * Added a stack trace showing that hierarchy
* Create a Parent Activity, which will be used to spawn children 2 levels deep. This allows for the error message to have a more detail stacktrace * Look for the stacktrace and effected activity within the error message.
goetzrrGit
force-pushed
the
feature/sim_error_stacktrace
branch
from
f3e4ed3 to
3cff3f4
Compare
Mythicaeda
reviewed
Jul 29, 2024
merlin-driver/src/main/java/gov/nasa/jpl/aerie/merlin/driver/engine/SimulationEngine.java
Outdated
Show resolved
Hide resolved
Mythicaeda
approved these changes
Jul 29, 2024
…ngine/SimulationEngine.java minor update with spacing Co-authored-by: Mythicaeda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides more detailed error information and improves debugging capabilities for Clipper. The error message includes the name of the affected activity type and provides a stack trace-like representation of the activity type hierarchy when errors occur in child activities.
{ "utcTimeDoy": "2023-001T01:02:00", "elapsedTime": "01:02:00.000000", "activityStackTrace": "DaemonTaskActivity |-DaemonCheckerSpawner |--DaemonCheckerActivity", "executingDirectiveId": 5, "executingActivityType": "DaemonTaskActivity" }Verification
e2e test pass and I am including a new parent activity, which will be used to spawn children 2 levels deep. This allows for the error message to have a more detailed stack trace.