Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a users guide to streamline resource framework #1494

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

DavidLegg
Copy link
Contributor

  • Tickets addressed: N/A
  • Review: By file
  • Merge strategy: Merge (no squash)

Description

This guide is meant to be a fairly condensed guide on how to use the streamline framework, organized primarily by worked example use cases, with some reference material.

The use cases were kindly provided by @bashbash, motivated by her early experience using Aerie with CADRE.

The only code change adds explicit support for "timer" style VariableClock resources, which tick down instead of up, through a few static methods. We could always get similar behavior from a stopwatch that ticked up to a positive time limit, but ticking down to zero is sometimes more intuitive.

Verification

N/A

Documentation

N/A

Future work

Continuing to aggregate explanations and worked examples. In particular,

  • For unstructured resources, which are currently only brushed over briefly. In particular, showing how to integrate SPICE or model something complex like an exponential, which are two use cases I called out but didn't demonstrate, would be good.
  • For unit-awareness features, which are currently omitted from the users guide entirely. This is intentional, as I don't feel fully comfortable with how unit awareness works currently. I'd like to take another run at those, focused on user-friendliness and extensibility, before we sink a lot of effort into describing how they currently work.

@DavidLegg DavidLegg requested a review from bashbash July 2, 2024 23:22
@DavidLegg DavidLegg mentioned this pull request Jul 10, 2024
@DavidLegg DavidLegg marked this pull request as ready for review August 6, 2024 17:15
@DavidLegg DavidLegg requested a review from a team as a code owner August 6, 2024 17:15
Copy link
Collaborator

@dandelany dandelany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DavidLegg - @mattdailis & I discussed this yesterday and I've been working my way through reading it. Very well written with lots of great use-cases, thank you! I didn't have time to test & tinker with all of the code examples, and I think this could still use a read-through from others (@cohansen or @adrienmaillard or @mattdailis) with an eye towards the fine details. That said, this is super valuable and meets the standards for new docs, especially for contrib, so I'm going to approve and merge so that it can be included with the Aerie 2.17.0 release.

David Legg and others added 2 commits August 7, 2024 16:25
This guide is meant to be a fairly condensed guide on how to use the streamline framework,
organized primarily by worked example use cases, with some reference material.

The use cases were kindly provided by Basak, motivated by her early experience of Aerie with CADRE.
Update the title and motivation for the streamline guide to better reflect the expanded scope provided by the example use cases section.
@dandelany dandelany force-pushed the documentation/streamline-locator-guide branch from 08b56dd to 8d7ab6c Compare August 7, 2024 23:25
@dandelany dandelany merged commit bf29adf into develop Aug 7, 2024
6 checks passed
@dandelany dandelany deleted the documentation/streamline-locator-guide branch August 7, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants