Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequencing e2e - Added channel/parameter and DB state test #1455

Merged

Conversation

goetzrrGit
Copy link
Contributor

Description

While prioritizing the release of the new sequencing editor for Clipper, I initially focused on fixing the existing e2e test. After the release, I created a new test to specifically verify the functionality of Channel and Parameter Dictionaries within Parcels. Additionally, I included another test to ensure data deletion triggers cascading modifications in the database across relevant tables.

Verification

Verified the test run locally without any issues.

@goetzrrGit goetzrrGit requested a review from a team as a code owner May 22, 2024 21:33
@goetzrrGit goetzrrGit requested review from dandelany and joswig May 22, 2024 21:33
@goetzrrGit goetzrrGit added test Adding missing tests, correcting existing tests, or test infrastructure sequencing Anything related to the sequencing domain labels May 22, 2024
@goetzrrGit goetzrrGit force-pushed the feature/e2e_sequencing_channel_parameter_support branch from b667737 to d36cb4f Compare May 22, 2024 21:34
@goetzrrGit goetzrrGit force-pushed the feature/e2e_sequencing_channel_parameter_support branch from d36cb4f to 5d58a39 Compare June 26, 2024 15:44
@dandelany dandelany requested a review from cohansen August 6, 2024 20:36
Copy link
Contributor

@cohansen cohansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@goetzrrGit goetzrrGit merged commit 1ce729a into develop Aug 6, 2024
6 checks passed
@goetzrrGit goetzrrGit deleted the feature/e2e_sequencing_channel_parameter_support branch August 6, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sequencing Anything related to the sequencing domain test Adding missing tests, correcting existing tests, or test infrastructure
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update Sequence Server Test (Channel, Parameter, Database)
2 participants