Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable expansion again #1433

Merged
merged 1 commit into from
May 2, 2024
Merged

Enable expansion again #1433

merged 1 commit into from
May 2, 2024

Conversation

goetzrrGit
Copy link
Contributor

@goetzrrGit goetzrrGit commented Apr 30, 2024

The new sequence editor broke sequence expansion. The adaptation should be optional as they are not needed currently by Clipper to expand their sequences.

Frontend changes:

NASA-AMMOS/aerie-ui#1261

* A sequence_adaptaion file should be optional for expansion sets. You don't need one in the current workflow
@goetzrrGit goetzrrGit requested a review from a team as a code owner April 30, 2024 21:31
@goetzrrGit goetzrrGit changed the base branch from develop to dev-sequencing April 30, 2024 21:32
JoelCourtney
JoelCourtney previously approved these changes May 2, 2024
@JoelCourtney
Copy link
Contributor

Actually maybe I shouldn't have approved because I don't know what the migration situation is now that the databases are merged. This might need a migration.

@JoelCourtney JoelCourtney dismissed their stale review May 2, 2024 20:45

migration might be needed

Copy link
Collaborator

@joswig joswig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good in my testing. Please refrain from merging until we've complete review on the UI

@joswig joswig merged commit 9c3aacc into dev-sequencing May 2, 2024
@joswig joswig deleted the fix/enable_expansion_again branch May 2, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants