Fix Versioning Scheduling Migration #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- FK creation/dropping was moved around relative to the data migration, and goal ids were properly migrated
skovati
approved these changes
Mar 28, 2024
|
Thanks @Mythicaeda and @skovati - I will cherry pick this commit (0d8da1f) on top of our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some foreign keys were being created prior to the data migration, which was causing issues since the table they were referencing was empty. The keys are now created after the data migration.
In the down migration, extra steps were added to the data migration to correctly update the remapped goal ids.
Verification
Tested against the aerie-dev database.
Documentation
No docs update
Future work