Improve Sequencing Queries #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: correctly sum `start_time` and `end_time`
* Using the span to calculate an activityInstance's 'startTime' and 'endTime'
Mythicaeda
added
fix
cohansen
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the Hasura queries used in the sequencing server to be faster and the DB queries to not join on unnecessary tables.
Verification
Manually testing the queries gave a time increase from ~17s with the old Hasura queries to ~1s with the new queries.
The DB queries are negligibly faster (66ms vs 55ms). These timings came from running the queries against the Clipper dev venue that was having the issue.
Documentation
No docs need to be updated
Future work