Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update db-test Postgres JDBC driver #1085

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

skovati
Copy link
Contributor

@skovati skovati commented Aug 9, 2023

Description

Missed an update to the postgres JDBC version for our database tests.

Verification

db-tests should pass as a sanity check, although this is a minor version bump, and shouldn't have breaking changes.

@skovati skovati added build Changes that affect the build system or external dependencies security A change that addresses a security concern labels Aug 9, 2023
@skovati skovati self-assigned this Aug 9, 2023
@skovati skovati requested a review from a team as a code owner August 9, 2023 16:50
@skovati skovati requested review from jmdelfa and Mythicaeda August 9, 2023 16:50
@skovati skovati requested review from camargo and removed request for jmdelfa August 9, 2023 16:50
@skovati skovati force-pushed the security/update-postgres-test-dep branch from 1805d7e to abcdcc9 Compare August 9, 2023 16:51
@skovati skovati temporarily deployed to e2e-test August 9, 2023 16:51 — with GitHub Actions Inactive
@camargo camargo changed the title update db-test postgres JDBC driver Update db-test Postgres JDBC driver Aug 9, 2023
Copy link
Member

@camargo camargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Mythicaeda
Copy link
Contributor

Mythicaeda commented Aug 9, 2023

More importantly than this being "just a minor version" update, we're using 42.6.0 everywhere else besides this one testImplementation. (meant to have that be the approval comment)

@camargo camargo force-pushed the security/update-postgres-test-dep branch from 6526007 to f27f350 Compare August 9, 2023 17:39
@camargo camargo temporarily deployed to e2e-test August 9, 2023 17:39 — with GitHub Actions Inactive
@camargo camargo merged commit 91b35f7 into develop Aug 9, 2023
@camargo camargo deleted the security/update-postgres-test-dep branch August 9, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies security A change that addresses a security concern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres, javalin and junit are vulnerable to security threats
3 participants