Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/command dictionary #1571

Merged
merged 19 commits into from
Dec 6, 2024
Merged

Feature/command dictionary #1571

merged 19 commits into from
Dec 6, 2024

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Dec 4, 2024

Resolves #1493

To test:

  1. Navigate to the /dictionaries page.
  2. Upload the /e2e-tests/data/command-dictionary.xml or a command dictionary of your choice.
  3. Navigate to /parcels
  4. Create a new parcel with that command dictionary selected
  5. Navigate to /sequencing
  6. Create a new workspace
  7. Create a new sequence using the parcel created in step 4
  8. Verify the new Command Dictionary tab is visible in the right panel
  9. Verify that clicking the tab displays a searchable listing all the commands in the dictionary
  10. Click on a command
  11. Verify that the arguments are displayed properly
  12. Click on the "copy" icon at the top right of the panel
  13. Verify that the command stem is successfully copied to the clipboard
  14. Click on the "close" icon at the top right of the panel
  15. Verify that the selected command is cleared

@duranb duranb requested a review from a team as a code owner December 4, 2024 21:41
@duranb duranb force-pushed the feature/command-dictionary branch from 1661ade to 785f33a Compare December 4, 2024 21:44
@duranb duranb force-pushed the feature/command-dictionary branch from ae2302c to dd8dd82 Compare December 5, 2024 20:40
Copy link
Contributor

@AaronPlave AaronPlave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one last tweak or two.

@duranb duranb force-pushed the feature/command-dictionary branch from 9e7abd0 to 27c1091 Compare December 6, 2024 17:23
@duranb duranb merged commit 2630a78 into develop Dec 6, 2024
5 checks passed
@duranb duranb deleted the feature/command-dictionary branch December 6, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command dictionary view
2 participants