-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/command dictionary #1571
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duranb
force-pushed
the
feature/command-dictionary
branch
from
December 4, 2024 21:44
1661ade
to
785f33a
Compare
AaronPlave
reviewed
Dec 5, 2024
AaronPlave
reviewed
Dec 5, 2024
AaronPlave
reviewed
Dec 5, 2024
src/components/sequencing/CommandPanel/CommandDictionary.svelte
Outdated
Show resolved
Hide resolved
AaronPlave
reviewed
Dec 5, 2024
duranb
force-pushed
the
feature/command-dictionary
branch
from
December 5, 2024 20:40
ae2302c
to
dd8dd82
Compare
AaronPlave
reviewed
Dec 5, 2024
AaronPlave
reviewed
Dec 6, 2024
AaronPlave
reviewed
Dec 6, 2024
AaronPlave
reviewed
Dec 6, 2024
AaronPlave
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one last tweak or two.
pull dictionary logic out from SelectedCommand into SequenceEditor for reuse
cleanup
duranb
force-pushed
the
feature/command-dictionary
branch
from
December 6, 2024 17:23
9e7abd0
to
27c1091
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1493
To test:
/dictionaries
page./e2e-tests/data/command-dictionary.xml
or a command dictionary of your choice./parcels
/sequencing
Command Dictionary
tab is visible in the right panel