Fix missing radix when serializing relative time milliseconds #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermak
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
cartermak
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
cartermak
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1566
Added a few tests and also adjusted the serialization for
microsecondsto pad to six digits instead of three ingetDurationTimeComponents, although I'm not sure it's used anywhere.Edit: reverted the change to pad microseconds to six digits -- I've been informed the intent is to break out subseconds into milliseconds and microseconds, so microseconds are meant to be balanced with milliseconds (e.g.,
1.234567 secondsis stored as1s 234ms 567us).