Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #1561 #1562

Merged
merged 1 commit into from
Dec 6, 2024
Merged

fix for #1561 #1562

merged 1 commit into from
Dec 6, 2024

Conversation

joswig
Copy link
Collaborator

@joswig joswig commented Nov 19, 2024

No description provided.

@goetzrrGit
Copy link
Contributor

@joswig is this ready to review. I tested it and it works on my end. I had Carter help me reproduce it with Aerie 3.0.1

@joswig joswig force-pushed the fix/extra_arg_quotes branch from 3dda9e8 to cc6cd0b Compare November 21, 2024 18:38
@joswig joswig marked this pull request as ready for review November 21, 2024 19:02
@joswig joswig requested a review from a team as a code owner November 21, 2024 19:02
@cartermak
Copy link
Member

@goetzrrGit can you confirm that you repro'd the issue on 3.0.1? I only ever saw it on Aerie 3.1, and just retested and don't see the issue on 3.0.0/3.0.1.

@cartermak
Copy link
Member

Repro'd #1561 in Aerie 3.1.1 again and then confirmed this UI fix addresses the issue.

@joswig joswig force-pushed the fix/extra_arg_quotes branch from cc6cd0b to 8a2d512 Compare December 6, 2024 01:04
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@joswig joswig merged commit aab60d8 into develop Dec 6, 2024
5 checks passed
@joswig joswig deleted the fix/extra_arg_quotes branch December 6, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants