Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Default View for Model #1554

Merged
merged 7 commits into from
Dec 5, 2024
Merged

Manage Default View for Model #1554

merged 7 commits into from
Dec 5, 2024

Conversation

AaronPlave
Copy link
Contributor

@AaronPlave AaronPlave commented Nov 12, 2024

Implements default view management in the Model Form. Closes #1027.

Testing:

  1. Create a plan and verify that the default view for the plan is the auto generated view
  2. Go to the models page and edit a model
  3. Select a view from the default view field on the left
  4. Save the model
  5. Go to the plan you created and ensure that the view you selected as default is loaded
  6. Create a new plan using that same model and navigate to the plan
  7. Ensure that the view you selected as default is loaded

Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one small comment, it looks good!

e2e-tests/tests/model.test.ts Outdated Show resolved Hide resolved
@AaronPlave AaronPlave force-pushed the feat/default-view-ui branch from 2c2052f to c1031ed Compare December 5, 2024 01:06
@AaronPlave AaronPlave merged commit a3d2612 into develop Dec 5, 2024
5 checks passed
@AaronPlave AaronPlave deleted the feat/default-view-ui branch December 5, 2024 01:17
@AaronPlave AaronPlave self-assigned this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set default view
2 participants