Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix goal plan specification deletion #1552

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Nov 11, 2024

Resolves #1551

To test:

  1. Create two plans
  2. Create a scheduling goal
  3. Open one plan
  4. Open the Scheduling Goals panel
  5. Click Manage Goals
  6. Select the created scheduling goal from step refactor: sim result activities property change #2
  7. Click Update
  8. Repeat steps 4-7 on the second plan
  9. Open the Manage Goals modal on either of the plans
  10. Deselect the goal
  11. Click Update
  12. Verify that the goal has been removed from the intended plan and is still present on the other plan

@duranb duranb requested a review from a team as a code owner November 11, 2024 19:19
@duranb duranb merged commit f3af153 into develop Nov 12, 2024
5 checks passed
@duranb duranb deleted the fix/1599-removing-scheduling-goals-from-plan branch November 12, 2024 02:42
dandelany pushed a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing scheduling goal from one plan removes it from all plans
2 participants