-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "scroll to activity" to activity directive table context menu (#1433) #1538
Add "scroll to activity" to activity directive table context menu (#1433) #1538
Conversation
6fe7401
to
7700195
Compare
0065737
to
3b02876
Compare
3b02876
to
be90d70
Compare
be90d70
to
1756a5d
Compare
1756a5d
to
19e005f
Compare
e9ce578
to
e52a883
Compare
e52a883
to
98a7dcc
Compare
@duranb ok i think i crushed it now, with unit tests and all! AND i handled the bounded case where the time range is bounded by maxTimeRange but should keep the same time range span, which it wasn't doing before, in the cases of the edges of the plan the time range span changed as you kept scrolling to activities, which was a bit funky. |
98a7dcc
to
22de8be
Compare
Any reason not to add this capability to the simulated activities table? |
22de8be
to
18663aa
Compare
18663aa
to
b209a63
Compare
@AaronPlave this task was just scoped to the activity directives. If we want to add it to the simulated activities table if we want to scroll to the start of the activity then the code would be pretty much the same, but it should be it's own task instead of adding more scope to this one. |
Sounds good, I'll make a ticket for that. #1553 |
b209a63
to
92ea8b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Resolves #1433
This one is my first substantial task so please check me I didn't do anything too crazy 😄
To test: