Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "scroll to activity" to activity directive table context menu (#1433) #1538

Merged

Conversation

ivydeliz
Copy link
Contributor

@ivydeliz ivydeliz commented Nov 5, 2024

Resolves #1433

This one is my first substantial task so please check me I didn't do anything too crazy 😄

To test:

  1. Open a Plan, go to the Activity Directives Table
  2. Right Click on a single activity directive, you should see "Scroll to Activity"
  3. Select a few items in the table, and right click, you should NOT see "Scroll to Activity"
  4. In the Timeline Histogram select a smaller time range
  5. From the Activity Directives Table, right click on activities at the start, middle and end of plan and click on "Scroll to Activity" in the context menu, it should scroll to show them if it is not visible, otherwise it just selects it in the timeline!

Screenshot 2024-11-05 at 3 42 22 PM

@ivydeliz ivydeliz force-pushed the feature/scroll-to-activity-from-activity-directives-table branch from 6fe7401 to 7700195 Compare November 5, 2024 22:38
@ivydeliz ivydeliz force-pushed the feature/scroll-to-activity-from-activity-directives-table branch from 0065737 to 3b02876 Compare November 5, 2024 22:53
@ivydeliz ivydeliz force-pushed the feature/scroll-to-activity-from-activity-directives-table branch from 3b02876 to be90d70 Compare November 5, 2024 22:57
@ivydeliz ivydeliz force-pushed the feature/scroll-to-activity-from-activity-directives-table branch from be90d70 to 1756a5d Compare November 5, 2024 22:59
@ivydeliz ivydeliz added the feature New feature or request label Nov 5, 2024
@ivydeliz ivydeliz force-pushed the feature/scroll-to-activity-from-activity-directives-table branch from 1756a5d to 19e005f Compare November 5, 2024 23:06
@ivydeliz ivydeliz marked this pull request as ready for review November 5, 2024 23:06
@ivydeliz ivydeliz requested a review from a team as a code owner November 5, 2024 23:06
@dandelany dandelany assigned ivydeliz and unassigned AaronPlave Nov 7, 2024
@ivydeliz ivydeliz force-pushed the feature/scroll-to-activity-from-activity-directives-table branch from e9ce578 to e52a883 Compare November 9, 2024 03:56
@ivydeliz ivydeliz force-pushed the feature/scroll-to-activity-from-activity-directives-table branch from e52a883 to 98a7dcc Compare November 9, 2024 03:57
@ivydeliz ivydeliz requested a review from duranb November 9, 2024 04:01
@ivydeliz
Copy link
Contributor Author

ivydeliz commented Nov 9, 2024

@duranb ok i think i crushed it now, with unit tests and all! AND i handled the bounded case where the time range is bounded by maxTimeRange but should keep the same time range span, which it wasn't doing before, in the cases of the edges of the plan the time range span changed as you kept scrolling to activities, which was a bit funky.

@ivydeliz ivydeliz force-pushed the feature/scroll-to-activity-from-activity-directives-table branch from 98a7dcc to 22de8be Compare November 9, 2024 04:05
@AaronPlave
Copy link
Contributor

Any reason not to add this capability to the simulated activities table?

@ivydeliz ivydeliz force-pushed the feature/scroll-to-activity-from-activity-directives-table branch from 22de8be to 18663aa Compare November 12, 2024 16:35
@ivydeliz ivydeliz requested a review from duranb November 12, 2024 16:40
@ivydeliz ivydeliz force-pushed the feature/scroll-to-activity-from-activity-directives-table branch from 18663aa to b209a63 Compare November 12, 2024 16:46
@ivydeliz
Copy link
Contributor Author

@AaronPlave this task was just scoped to the activity directives. If we want to add it to the simulated activities table if we want to scroll to the start of the activity then the code would be pretty much the same, but it should be it's own task instead of adding more scope to this one.

@AaronPlave
Copy link
Contributor

AaronPlave commented Nov 12, 2024

@AaronPlave this task was just scoped to the activity directives. If we want to add it to the simulated activities table if we want to scroll to the start of the activity then the code would be pretty much the same, but it should be it's own task instead of adding more scope to this one.

Sounds good, I'll make a ticket for that. #1553

@ivydeliz ivydeliz force-pushed the feature/scroll-to-activity-from-activity-directives-table branch from b209a63 to 92ea8b1 Compare November 12, 2024 19:09
@ivydeliz ivydeliz requested a review from duranb November 12, 2024 19:40
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ivydeliz ivydeliz merged commit b99e922 into develop Nov 12, 2024
5 checks passed
@ivydeliz ivydeliz deleted the feature/scroll-to-activity-from-activity-directives-table branch November 12, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "scroll to activity" to activity directive table context menu
3 participants