Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequencing command form builder css gutter fix #1533

Merged

Conversation

AaronPlave
Copy link
Contributor

Only display sequencing command form builder gutter if needed. Previously this gutter would show up on the main sequences page even though unused and if you dragged it you'd get an error.

@AaronPlave AaronPlave requested a review from a team as a code owner October 30, 2024 17:20
@AaronPlave AaronPlave requested review from cohansen and removed request for dandelany October 30, 2024 17:20
@AaronPlave AaronPlave force-pushed the fix/conditionally-display-sequence-editor-gutter branch from 81f81db to 4dcbbd3 Compare October 31, 2024 17:59
Copy link
Collaborator

@joswig joswig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AaronPlave
Copy link
Contributor Author

@joswig looks like you may have done a merge from develop into this branch, I can try to rebase that out unless there's a particular reason to keep it in there?

@joswig
Copy link
Collaborator

joswig commented Nov 4, 2024

@joswig looks like you may have done a merge from develop into this branch, I can try to rebase that out unless there's a particular reason to keep it in there?

feel free to rebase it out, I had done the merge commit to enable squash and merge in the web ui and confirm the tests still pass

Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@AaronPlave AaronPlave force-pushed the fix/conditionally-display-sequence-editor-gutter branch from bec4f6c to 6483878 Compare November 5, 2024 21:51
@AaronPlave AaronPlave merged commit 1e0ffdc into develop Nov 5, 2024
5 checks passed
@AaronPlave AaronPlave deleted the fix/conditionally-display-sequence-editor-gutter branch November 5, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants