Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear resources on plan branch #1530

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Clear resources on plan branch #1530

merged 1 commit into from
Oct 30, 2024

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Oct 29, 2024

Resolves #1520

To test:

  1. Create a bananation plan
  2. Run some simulations
  3. Create a new branch off of that plan
  4. Verify that the plotted resources from the parent plan are now cleared from the timeline

@duranb
allow null in subscribable store
2f534ed 
clear out resources on plan change
@duranb duranb requested a review from a team as a code owner October 29, 2024 23:44
AaronPlave
AaronPlave approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@AaronPlave AaronPlave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duranb duranb merged commit 6a4afaa into develop Oct 30, 2024
5 checks passed
@duranb duranb deleted the fix/1520-reset-resources-on-plan-branch branch October 30, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronPlave AaronPlave AaronPlave approved these changes

@dandelany dandelany Awaiting requested review from dandelany dandelany is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@joswig joswig Awaiting requested review from joswig joswig is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI shows parent plan's selected sim results after branching a plan
2 participants
@duranb @AaronPlave