Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter info icon misaligned in ParameterRecSeries or ParameterRecStruct (#1473) #1529

Merged

Conversation

ivydeliz
Copy link
Contributor

Fixes #1473.

In May there was a major refactor that made the default height of the Collapse widget 32px, likely to fit some other place where Collapse is set, but it seems the Parameters should all be 24px in height. This caused the ParameterRecSeries and ParameterRecStruct to inherit the 32px height, which is inconsistent with the other parameters and then the info icon was then misaligned.

I can't really find where the height of parameters is set overall so I kept it at the level of ParameterRec but if you can pull this up one level higher we can pass the same height for all parameters widgets.

Right now other places, like Definition section, uses 32px height.

To test:

  1. Create a plan with banananation model
  2. Add a ParameterTest Directive to the plan
  3. Click on it and scroll to the parameters that say array, list, struct, etc. basically all the ones you see a collapse arrow
  4. Hover over the parameter and check the info icon is aligned

@ivydeliz ivydeliz requested a review from a team as a code owner October 29, 2024 21:29
@ivydeliz ivydeliz added the fix A bug fix label Oct 29, 2024
@ivydeliz ivydeliz closed this Oct 29, 2024
@ivydeliz ivydeliz force-pushed the fix/parameter-array-widget-info-icon-collapse-height branch from 801ad8e to cd7c918 Compare October 29, 2024 21:34
@ivydeliz ivydeliz reopened this Oct 29, 2024
@ivydeliz
Copy link
Contributor Author

OOOOR we can change the default back to 24, and pass in 32px when it's really needed. Going to ask @AaronPlave and @duranb for some guidance here of what's your opinion on how we should fix it.

src/components/Collapse.svelte Outdated Show resolved Hide resolved
@ivydeliz ivydeliz force-pushed the fix/parameter-array-widget-info-icon-collapse-height branch from 5f6fd38 to e646f59 Compare November 4, 2024 23:15
@ivydeliz ivydeliz requested a review from AaronPlave November 4, 2024 23:34
Copy link
Contributor

@AaronPlave AaronPlave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivydeliz ivydeliz force-pushed the fix/parameter-array-widget-info-icon-collapse-height branch from e646f59 to 75f847f Compare November 5, 2024 23:08
@ivydeliz ivydeliz merged commit f4295ea into develop Nov 5, 2024
5 checks passed
@ivydeliz ivydeliz deleted the fix/parameter-array-widget-info-icon-collapse-height branch November 5, 2024 23:19
@joswig joswig added this to the FY25 Q1 - UI Bug Fixes milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Parameter info icon misaligned in certain cases
3 participants