Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sequencing page resizing behavior (#1457) #1528

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Fix sequencing page resizing behavior (#1457) #1528

merged 1 commit into from
Nov 1, 2024

Conversation

ivydeliz
Copy link
Contributor

Fixes #1457

To test:

  1. Navigate to /sequencing
  2. Attempt to resize the workspaces panel by dragging the left resize handle - the left and middle should update widths
  3. Attempt to resize the sequences panel by dragging the right resize handle - the middle and right panel should update widths

@ivydeliz ivydeliz requested a review from a team as a code owner October 29, 2024 19:13
@ivydeliz ivydeliz added the fix A bug fix label Oct 29, 2024
AaronPlave
AaronPlave approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@AaronPlave AaronPlave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivydeliz ivydeliz force-pushed the fix/sequencing-fix-resizing-behavior branch from 3f64cb1 to d17adae Compare November 1, 2024 20:52
@ivydeliz ivydeliz merged commit 953b7ca into develop Nov 1, 2024
5 checks passed
@ivydeliz ivydeliz deleted the fix/sequencing-fix-resizing-behavior branch November 1, 2024 21:10
@joswig joswig added this to the FY25 Q1 - UI Bug Fixes milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronPlave AaronPlave AaronPlave approved these changes

@duranb duranb Awaiting requested review from duranb duranb is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@joswig joswig Awaiting requested review from joswig joswig is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees

@ivydeliz ivydeliz

Labels
fix A bug fix
Projects
Aerie
Status: Done
Milestone
FY25 Q1 - UI Bug Fixes
Development

Successfully merging this pull request may close these issues.

Incorrect sequencing page resizing behavior
3 participants
@ivydeliz @AaronPlave @joswig