Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag deletion specificity fixes #1521

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Conversation

AaronPlave
Copy link
Contributor

Ensures that all tag association deletion queries are specific to the appropriate entity.

Closes #1519

@AaronPlave AaronPlave marked this pull request as ready for review October 23, 2024 17:26
@AaronPlave AaronPlave requested a review from a team as a code owner October 23, 2024 17:26
@AaronPlave AaronPlave self-assigned this Oct 23, 2024
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@AaronPlave AaronPlave merged commit 2f304ce into develop Oct 23, 2024
5 checks passed
@AaronPlave AaronPlave deleted the fix/1519/tag-deletion-fixes branch October 23, 2024 23:30
dandelany pushed a commit that referenced this pull request Nov 20, 2024
* Fix tag directive tag deletion

* Fix constraint tag deletion specificity

* Fix expansion rule tag deletion specificity

* Fix plan tag deletion specificity

* Fix scheduling condition tag deletion specificity

* Fix scheduling goal tag deletion specificity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing a Tag from a Directive Removes it from ALL Directives in Aerie
2 participants