Bugfix for Sequence Customization #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdailis
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
requested changes
Oct 21, 2024
mattdailis
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
mattdailis
force-pushed
the
bugfix/updated-customization-interface
branch
from
67dc1ef to
1b4a1b4
Compare
mattdailis
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
|
Tested and confirmed this version still fixes the bug. Agreed that the type change ought to be part of a bigger audit (and probably ought to feed into #1499 anyway). |
mattdailis
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
|
Latest commit ensures that the output is a string using string interpolation |
mattdailis
force-pushed
the
bugfix/updated-customization-interface
branch
from
9a508db to
fa00a28
Compare
mattdailis
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
mattdailis
force-pushed
the
bugfix/updated-customization-interface
branch
from
fa00a28 to
87baa3a
Compare
mattdailis
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
mattdailis
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
mattdailis
force-pushed
the
bugfix/updated-customization-interface
branch
from
6690d15 to
057d24e
Compare
mattdailis
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
approved these changes
Oct 22, 2024
|
Tested and working for me! Thanks all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening #1514 as a branch rather than a fork
Small fix that probably came in when the interface changed from mutable
SeqJSONto stringified JSON.Closes #1515