Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double click plan row to open plan #1511

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Double click plan row to open plan #1511

merged 1 commit into from
Oct 16, 2024

Conversation

ivydeliz
Copy link
Contributor

Resolves: #1438

To test:

  1. Have a plans table that has a few plans on it
  2. Double click on a plan row
  3. Give it a second and the plan should open up in the same tab

@ivydeliz ivydeliz requested a review from a team as a code owner October 15, 2024 22:50
@ivydeliz ivydeliz added the feature New feature or request label Oct 15, 2024
@ivydeliz ivydeliz force-pushed the feature/double-click-to-open-plan branch from e695175 to e331a7b Compare October 15, 2024 22:57
duranb
duranb requested changes Oct 16, 2024
View reviewed changes
src/routes/plans/+page.svelte Outdated Show resolved Hide resolved
duranb
duranb approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ivydeliz ivydeliz force-pushed the feature/double-click-to-open-plan branch from 9ad29eb to 226986f Compare October 16, 2024 18:51
@ivydeliz ivydeliz merged commit 063b04f into develop Oct 16, 2024
5 checks passed
@ivydeliz ivydeliz deleted the feature/double-click-to-open-plan branch October 16, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duranb duranb duranb approved these changes

@AaronPlave AaronPlave AaronPlave approved these changes

@joswig joswig Awaiting requested review from joswig joswig is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double-click to open plan on plan page
3 participants
@ivydeliz @AaronPlave @duranb