Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle nullable receiving and supplying plans for merge reviews #1508

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Handle nullable receiving and supplying plans for merge reviews #1508

merged 6 commits into from
Nov 6, 2024

Conversation

AaronPlave
Copy link
Contributor

@AaronPlave AaronPlave commented Oct 14, 2024 •
edited
Loading

Closes #1507 .

TODO:

  • e2e tests
  • Should a user be allowed to begin a review if the source plan has been deleted?
  • What should we do about merge requests that are stuck in pending if we don't do ^
  • Should a user be allowed to withdraw a review if the target plan has been deleted?

@AaronPlave AaronPlave self-assigned this Oct 14, 2024
@AaronPlave AaronPlave force-pushed the fix/nullable-plan-for-merge branch from a925279 to 68d4fea Compare October 15, 2024 15:30
@AaronPlave AaronPlave force-pushed the fix/nullable-plan-for-merge branch from 68d4fea to c2c7e3f Compare October 15, 2024 15:34
@AaronPlave AaronPlave force-pushed the fix/nullable-plan-for-merge branch from c2c7e3f to 1f20721 Compare October 24, 2024 21:36
@AaronPlave AaronPlave marked this pull request as ready for review October 29, 2024 20:36
@AaronPlave AaronPlave requested a review from a team as a code owner October 29, 2024 20:36
@AaronPlave AaronPlave force-pushed the fix/nullable-plan-for-merge branch from 5311cdb to b62fa44 Compare October 30, 2024 18:02
@AaronPlave AaronPlave force-pushed the fix/nullable-plan-for-merge branch from 1f6d29e to 159ada8 Compare October 30, 2024 18:19
@AaronPlave AaronPlave force-pushed the fix/nullable-plan-for-merge branch from 159ada8 to a26aef5 Compare October 31, 2024 17:59
@AaronPlave AaronPlave force-pushed the fix/nullable-plan-for-merge branch from a26aef5 to 98990dc Compare November 5, 2024 17:02
@AaronPlave AaronPlave force-pushed the fix/nullable-plan-for-merge branch from 208359f to a2e9990 Compare November 5, 2024 22:57
duranb
duranb approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@AaronPlave AaronPlave force-pushed the fix/nullable-plan-for-merge branch from a2e9990 to 47ad55d Compare November 5, 2024 23:24
@AaronPlave AaronPlave merged commit b07bee7 into develop Nov 6, 2024
5 checks passed
@AaronPlave AaronPlave deleted the fix/nullable-plan-for-merge branch November 6, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duranb duranb duranb approved these changes

@dandelany dandelany Awaiting requested review from dandelany dandelany is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@joswig joswig Awaiting requested review from joswig joswig is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees

@AaronPlave AaronPlave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to open merge request
2 participants
@AaronPlave @duranb