-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local and Parameter Blocks #1494
Conversation
2776a8a
to
522e146
Compare
522e146
to
e1db224
Compare
e1db224
to
8404c92
Compare
8404c92
to
8f6ef3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to fix the linter typo as that was unclear when I was testing, the others are style and just my opinion.
Functionally it works well, my testing focused on folding and seq.json inspection.
I'll note that even when @LOCALS_BEGIN is present, the content assist can suggest an @Locals directive which will lint as an error. This is a minor issue and neither unique nor new, but I'd like to see how we can reduce on completion suggestion set to valid options. This may be impractical since we support custom linting
Thank you for the review. I fixed the issues you listed in the PR. We can beef up the autocompletion further and should be okay with custom linting as you can modify/override the autocompletion within the adaptation file |
b266379
to
4805ebc
Compare
* Added new directive @INPUT_PARAMETER_BEGIN/END and @LOCALS_BEGIN/END
* Checking both the new and old Parameters @INPUT_PARAMS and @INPUT_PARAMS_BEGIN * Checking both the new and old Locals @Locals and @LOCALS_BEGIN
* new LOCAL and INPUT_PARAMS blocks * SeqJson export of Local and Parameters are fully supported now * Update the unit test as well
* new LOCAL and INPUT_PARAMS blocks * Import full SeqJSON spec for Locals and Parameters * Update the unit test as well
* Updated the unit test
4805ebc
to
236a511
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my feedback, I'm good merging when @duranb and @goetzrrGit are in agreement on the other items
236a511
to
f547fe9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Closes #1460
Adding new directives to the SeqN Grammer to support Parameters and Locals blocks.
Testing:
You should be able to use the old grammer
As well as the new grammar. The new grammar should be collapsable.
Verify round-tripping works by exporting a seqJson and reimporting it and verify that the Locals and Input_params are correct.