New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Upload external resources #1492

Merged

dandelany merged 14 commits into develop from feature/upload-external-resources

Oct 23, 2024

Collaborator

duranb commented Oct 7, 2024 •

edited

Loading

___REQUIRES_GATEWAY_PR___="112"

Partially resolves: #1424

To test:

Upload a model
Create a plan using that model
Open the "Activity & Resources" panel on that plan
Click the "Resources" tab in that panel
Click the "Upload Resources" icon button
Verify that a file upload input pops up below the button
Choose the test file /e2e-test/data/external-dataset.json
Click the "Upload" button
Verify that the new resources show up in the resources list below
Repeat steps 7-9 but with the /e2e-test/data/external-dataset.csv file

duranb requested a review from a team as a code owner

October 7, 2024 21:48

duranb requested review from dandelany, AaronPlave and joswig

October 7, 2024 21:48

duranb had a problem deploying to test-workflow

October 7, 2024 21:48

— with

GitHub Actions Failure

duranb mentioned this pull request

Feature: Upload external datasets NASA-AMMOS/aerie-gateway#112

Merged

duranb had a problem deploying to test-workflow

October 7, 2024 21:49

— with

GitHub Actions Failure

duranb had a problem deploying to test-workflow

October 7, 2024 21:52

— with

GitHub Actions Failure

duranb had a problem deploying to test-workflow

October 7, 2024 21:53

— with

GitHub Actions Failure

duranb had a problem deploying to test-workflow

October 7, 2024 23:08

— with

GitHub Actions Failure

dandelany had a problem deploying to test-workflow

October 10, 2024 23:23

— with

GitHub Actions Failure

dandelany temporarily deployed to test-workflow

October 14, 2024 23:36

— with

GitHub Actions Inactive

duranb force-pushed the feature/upload-external-resources branch from 1907b71 to f814ab3 Compare

October 15, 2024 01:04

duranb temporarily deployed to test-workflow

October 15, 2024 01:04

— with

GitHub Actions Inactive

AaronPlave reviewed

View reviewed changes

src/components/ResourceList.svelte Show resolved Hide resolved

AaronPlave reviewed

View reviewed changes

src/utilities/effects.ts Show resolved Hide resolved

AaronPlave reviewed

View reviewed changes

src/routes/plans/[id]/+page.svelte Outdated Show resolved Hide resolved

AaronPlave reviewed

View reviewed changes

src/routes/plans/[id]/+page.svelte Outdated Show resolved Hide resolved

duranb temporarily deployed to test-workflow

October 21, 2024 21:53

— with

GitHub Actions Inactive

Collaborator Author

duranb commented Oct 21, 2024

@AaronPlave should be ready for another look at. Thanks!

duranb force-pushed the feature/upload-external-resources branch from 867580f to d5ad438 Compare

October 21, 2024 21:54

duranb temporarily deployed to test-workflow

October 21, 2024 21:54

— with

GitHub Actions Inactive

AaronPlave reviewed

View reviewed changes

src/components/ResourceList.svelte Outdated Show resolved Hide resolved

AaronPlave reviewed

View reviewed changes

src/components/ResourceList.svelte Show resolved Hide resolved

AaronPlave reviewed

View reviewed changes

src/components/TimelineItemList.svelte Show resolved Hide resolved

duranb force-pushed the feature/upload-external-resources branch from d5ad438 to 86bdcbf Compare

October 22, 2024 20:11

duranb temporarily deployed to test-workflow

October 22, 2024 20:11

— with

GitHub Actions Inactive

duranb had a problem deploying to test-workflow

October 22, 2024 23:24

— with

GitHub Actions Failure

AaronPlave approved these changes

View reviewed changes


          fix collapse clickthrough

733bf31

duranb added 12 commits

October 22, 2024 16:50


          move scheduling enum file to enums directory

c879818


          Add ability to upload external dataset to plan

745ebdb


          add ability to associate simulation dataset to external datasets

88572c3


          styling

5f65006


          add e2e tests for dataset uploading

8084ce4


          update design

3e2a469


          add toasts for external dataset upload

8ef04e5


          cleanup

9e24ad6


          ensure unique resource name

24c1d6c


          add styling

db9a645


          fix unique profile names

7c08db8


          fix styling

86df418

fix unique list of types

duranb force-pushed the feature/upload-external-resources branch from 67354e3 to 86df418 Compare

October 22, 2024 23:50

duranb had a problem deploying to test-workflow

October 22, 2024 23:50

— with

GitHub Actions Failure


          fix test

ad67784

duranb temporarily deployed to test-workflow

October 22, 2024 23:51

— with

GitHub Actions Inactive

Collaborator

dandelany commented Oct 23, 2024

Tested locally with the gateway PR which has merged - merging this for release. Thanks!

dandelany merged commit 08e06cb into develop

5 checks passed

dandelany deleted the feature/upload-external-resources branch

October 23, 2024 01:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AaronPlave AaronPlave approved these changes

dandelany Awaiting requested review from dandelany dandelany is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

joswig Awaiting requested review from joswig joswig is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Labels

None yet