Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow parsing month of October #1489

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Allow parsing month of October #1489

merged 1 commit into from
Oct 3, 2024

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Oct 3, 2024

Fixes an issue exposed via plan import where a plan file that had a start time in October did not parse the date properly due to dumb regex...

@duranb duranb requested a review from a team as a code owner October 3, 2024 20:55
@duranb duranb added the fix A bug fix label Oct 3, 2024
AaronPlave
AaronPlave approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@AaronPlave AaronPlave left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need October though? /s

@duranb
Copy link
Collaborator Author

duranb commented Oct 3, 2024

Do we really need October though? /s

Debatable

@duranb duranb merged commit 90b9f25 into develop Oct 3, 2024
5 checks passed
@duranb duranb deleted the fix/time-parsing-october branch October 3, 2024 23:03
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
@duranb
Allow parsing month of October (#1489)
1f5e01a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronPlave AaronPlave AaronPlave approved these changes

@dandelany dandelany Awaiting requested review from dandelany dandelany is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@joswig joswig Awaiting requested review from joswig joswig is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees
No one assigned
Labels
fix A bug fix
Projects
Aerie
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duranb @AaronPlave