Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/vml grammar #1472

Merged
merged 86 commits into from
Oct 30, 2024
Merged

Feat/vml grammar #1472

merged 86 commits into from
Oct 30, 2024

Conversation

joswig
Copy link
Collaborator

@joswig joswig commented Sep 23, 2024

This PR encompasses initial support for VML 2.0.11 editing. The grammar is based on DOC-000477 Rev C., with minor changes related to Bison vs Lezer differences, and some minor implementation choices when grammar appeared to have a typo.

VML capabilities are mapped to file extension.

Sample sequences and dictionaries are available from @joswig, but are not cleared for release, so treat as ITAR.

Follow up actions

  • More polish on context awareness on content assist, there's a minimal implementation to show potential capabilities. Low hanging fruit to add more, but trying to get this PR merged.
  • Add support for block library, once that's done then treat spawn and call statements in similar manner to issue
  • Consider moving CDL dictionary parsing code to the server. We should decide on XTCE path forward first, but the current implementation is inconsistent with rest of application
  • more testing, only 2 test sequences have been provided, will work with missions as part of User Acceptance Testing

@joswig joswig added the DON'T MERGE Do Not Merge This Branch label Sep 23, 2024
@duranb
Copy link
Collaborator

duranb commented Oct 28, 2024

I'm a little concerned with the vmlMode for SequenceEditor because it bypasses the adaptation flow. Can we do a follow up right after this is merged? I know there's a chance that this will be pulled out of core, but I just want to make sure that in the off chance that it does stay in, that it's integrated properly to work in conjunction with adaptations. For example, right now adaptations require an inputFormat. So if this is baked into Aerie, we should handle cases where they don't match or make the inputFormat drive vmlMode instead of the sequence name.

Copy link
Contributor

@cohansen cohansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a cursory glance and it all looked good. Still curious how our decisions with language support will effect this.

@joswig
Copy link
Collaborator Author

joswig commented Oct 30, 2024

I'm a little concerned with the vmlMode for SequenceEditor because it bypasses the adaptation flow. Can we do a follow up right after this is merged? I know there's a chance that this will be pulled out of core, but I just want to make sure that in the off chance that it does stay in, that it's integrated properly to work in conjunction with adaptations. For example, right now adaptations require an inputFormat. So if this is baked into Aerie, we should handle cases where they don't match or make the inputFormat drive vmlMode instead of the sequence name.

That sounds good, I think it will be a couple of steps to get there and publishing the adaptation types is one of the next ones up.

Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@joswig
Copy link
Collaborator Author

joswig commented Oct 30, 2024

Also will follow up with

#1534

@joswig joswig merged commit 1747bb9 into develop Oct 30, 2024
5 checks passed
@joswig joswig deleted the feat/vml_grammar branch October 30, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants