Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1468

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Update dependencies #1468

merged 2 commits into from
Sep 18, 2024

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Sep 18, 2024

ag-grid made some icon changes, so updates were needed to replicate the previous column filter icons and fix CSS selectors in tests

@duranb duranb requested a review from a team as a code owner September 18, 2024 20:44
@duranb duranb added the refactor A code change that neither fixes a bug nor adds a feature label Sep 18, 2024
@dandelany
Copy link
Collaborator

dandelany commented Sep 18, 2024

@duranb did you use the codemod provided by ag-grid to generate these changes? and/or go through the changelogs for releases to catch any other breaking changes? These changes alone seem OK but just want to make sure we're being thorough on the upgrade.

@duranb
Copy link
Collaborator Author

duranb commented Sep 18, 2024

@dandelany I didn't know about codemod, but running it now yields no relevant changes. I also briefly went through their changelog, but mostly relied on the e2e tests and clicking through the UI to verify everything is working as intended.

Copy link
Collaborator

@dandelany dandelany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @duranb - looks good 👍

@dandelany dandelany merged commit 3f943e4 into develop Sep 18, 2024
5 checks passed
@dandelany dandelany deleted the refactor/update-deps branch September 18, 2024 23:40
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
* update dependencies

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants