-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FCPL branch enhancements #1455
Merged
Merged
FCPL branch enhancements #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code_folding_blocks.mov |
joswig
temporarily deployed
to
test-workflow
September 12, 2024 23:46 — with
GitHub Actions
Inactive
block_highlighting.mov |
joswig
temporarily deployed
to
test-workflow
September 13, 2024 01:01 — with
GitHub Actions
Inactive
joswig
temporarily deployed
to
test-workflow
September 13, 2024 01:01 — with
GitHub Actions
Inactive
joswig
temporarily deployed
to
test-workflow
September 13, 2024 01:02 — with
GitHub Actions
Inactive
joswig
temporarily deployed
to
test-workflow
September 13, 2024 01:18 — with
GitHub Actions
Inactive
joswig
temporarily deployed
to
test-workflow
September 14, 2024 00:25 — with
GitHub Actions
Inactive
joswig
temporarily deployed
to
test-workflow
September 17, 2024 00:21 — with
GitHub Actions
Inactive
joswig
had a problem deploying
to
test-workflow
September 17, 2024 00:27 — with
GitHub Actions
Failure
joswig
temporarily deployed
to
test-workflow
September 17, 2024 00:27 — with
GitHub Actions
Inactive
joswig
temporarily deployed
to
test-workflow
September 18, 2024 00:36 — with
GitHub Actions
Inactive
goetzrrGit
previously requested changes
Sep 18, 2024
joswig
had a problem deploying
to
test-workflow
September 19, 2024 20:31 — with
GitHub Actions
Failure
duranb
reviewed
Sep 19, 2024
duranb
requested changes
Sep 19, 2024
joswig
temporarily deployed
to
test-workflow
September 19, 2024 21:23 — with
GitHub Actions
Inactive
joswig
temporarily deployed
to
test-workflow
September 19, 2024 21:55 — with
GitHub Actions
Inactive
@joswig To work with psyche, we'll need the user versions of each of these commands in this block:
|
joswig
temporarily deployed
to
test-workflow
September 26, 2024 16:16 — with
GitHub Actions
Inactive
joswig
temporarily deployed
to
test-workflow
September 26, 2024 16:34 — with
GitHub Actions
Inactive
joswig
had a problem deploying
to
test-workflow
September 26, 2024 16:41 — with
GitHub Actions
Failure
joswig
temporarily deployed
to
test-workflow
September 26, 2024 17:00 — with
GitHub Actions
Inactive
cohansen
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
duranb
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* folding for seqN conditionals, waits, and loops * outlining of paired blocks, may change definition of paired * highlight if, else, end together * added linting for block structure * auto-indent blocks and fix folding when there's indentation * only show last unclosed block error * removed some unused parameters * support alternate loop construct names * clear selection after indent on open, make function return types explicit * better variable name and remove unused parameter * more detailed parameter name, explicit return types * restore branch structure checking * removed some unused parameters * create USER_ stems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1412
SeqN/FCPL
I've deferred reorganizing some code to minimize merge conflicts with other work in progress. There will be a different PR for VML implementation
Requires testing with new Clipper or Psyche adaptation (from Cody)