Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Show simulation history arguments #1450

Merged
merged 7 commits into from
Sep 16, 2024

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Sep 4, 2024

Resolves #1419

To test:

  1. Create a banananation plan and navigate into it
  2. Add some activities
  3. Run a simulation
  4. Open the simulation panel
  5. Verify that there is now a collapsible Arguments section for each simulation under "Simulation History"
  6. Change some arguments for the simulation
  7. Run another simulation
  8. Expand each Arguments section under the "Simulation History"
  9. Verify that the values of the arguments are accurately displayed

@duranb duranb requested a review from a team as a code owner September 4, 2024 22:36
@duranb duranb force-pushed the feature/show-simulation-history-arguments branch from 7aef78b to 7cc2b82 Compare September 9, 2024 23:51
@dandelany dandelany force-pushed the feature/show-simulation-history-arguments branch from 7cc2b82 to a7415bc Compare September 16, 2024 17:47
Copy link
Collaborator

@dandelany dandelany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @duranb! Tested locally by sim'ing banananation with lots of different arguments. Just one small question above

@duranb duranb merged commit 80d51a9 into develop Sep 16, 2024
5 checks passed
@duranb duranb deleted the feature/show-simulation-history-arguments branch September 16, 2024 23:28
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
* hide buttons for resetting if disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to see simulation configuration used for simulation in UI
2 participants