-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Show simulation history arguments #1450
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duranb
force-pushed
the
feature/show-simulation-history-arguments
branch
from
September 9, 2024 23:51
7aef78b
to
7cc2b82
Compare
dandelany
force-pushed
the
feature/show-simulation-history-arguments
branch
from
September 16, 2024 17:47
7cc2b82
to
a7415bc
Compare
dandelany
temporarily deployed
to
test-workflow
September 16, 2024 17:48 — with
GitHub Actions
Inactive
dandelany
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @duranb! Tested locally by sim'ing banananation with lots of different arguments. Just one small question above
duranb
had a problem deploying
to
test-workflow
September 16, 2024 21:22 — with
GitHub Actions
Failure
duranb
had a problem deploying
to
test-workflow
September 16, 2024 21:25 — with
GitHub Actions
Error
duranb
temporarily deployed
to
test-workflow
September 16, 2024 22:19 — with
GitHub Actions
Inactive
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* hide buttons for resetting if disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1419
To test:
Arguments
section for each simulation under "Simulation History"Arguments
section under the "Simulation History"