FPrime Dictionary and Sequence Support #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetzrrGit
had a problem deploying
to
test-workflow
GitHub Actions
Failure
duranb
requested changes
Sep 3, 2024
goetzrrGit
had a problem deploying
to
test-workflow
GitHub Actions
Failure
goetzrrGit
had a problem deploying
to
test-workflow
GitHub Actions
Failure
goetzrrGit
force-pushed
the
feature/fprime-sequencing
branch
from
b8f9531 to
3d25bd9
Compare
goetzrrGit
had a problem deploying
to
test-workflow
GitHub Actions
Failure
goetzrrGit
had a problem deploying
to
test-workflow
GitHub Actions
Failure
goetzrrGit
had a problem deploying
to
test-workflow
GitHub Actions
Failure
goetzrrGit
had a problem deploying
to
test-workflow
GitHub Actions
Failure
dandelany
had a problem deploying
to
test-workflow
GitHub Actions
Failure
dandelany
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
goetzrrGit
force-pushed
the
feature/fprime-sequencing
branch
from
3d25bd9 to
b70baa9
Compare
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
reviewed
Sep 26, 2024
* Return information about the 3 dictionary that the sequencing server could have parsed.
goetzrrGit
force-pushed
the
feature/fprime-sequencing
branch
from
b70baa9 to
fce8f76
Compare
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
requested changes
Oct 14, 2024
goetzrrGit
force-pushed
the
feature/fprime-sequencing
branch
from
fce8f76 to
414f23f
Compare
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
* Remove the logic to determine which dictionary we are uploading, offloading this responsibility to the dictionary parser plugin
* FPrime supports deeply nested arguments
* var_strings don't add "" if a default value isn't available
goetzrrGit
force-pushed
the
feature/fprime-sequencing
branch
from
414f23f to
d69cb95
Compare
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Update GQL CreateDictionary call. * Return information about the 3 dictionary that the sequencing server could have parsed. * Pass the raw dictionary to the server * Remove the logic to determine which dictionary we are uploading, offloading this responsibility to the dictionary parser plugin * Added support for nested repeat args * FPrime supports deeply nested arguments * Fix bug with auto-complete * var_strings don't add "" if a default value isn't available * Fix e2e test * Minor bug fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
___REQUIRES_AERIE_PR___="1542"This PR adds support for FPrime dictionary and sequencing.
GQL CreateDictionary call update: The GQL CreateDictionary call has been modified to return information about all three potential dictionaries that the sequencing server could have parsed.
Raw dictionary passing: The logic to determine the type of dictionary being uploaded has been removed. This responsibility is now delegated to the dictionary parser plugin
Auto-complete bug fix: The auto-complete feature has been corrected to ensure that variable strings are enclosed in double quotes (""), even when a default value is not provided.
FPrime Sequence Adaptation:
https://github.com/NASA-AMMOS/FPrime-Sequence-Adaptation
The backend PR is here:
NASA-AMMOS/aerie#1542