-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequence Editor Ground epoch time tag #1443
Conversation
b5e0b92
to
77fbe2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! pending @joswig's 👀 on the grammar
I'm good with the grammar change if @shaheerk94 concurs with the resulting language The format differed because, I thought the name should go before the delta, I'll also add that the delta is unrestricted in the schema, but downstream tools aren't as flexible and I consider that a required schema update that shouldn't block this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shaheerk94 Would you confirm if this lines up with #1368 sufficiently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New format will work - agree with Chet we may need to add more restrictions in the future but that doesn't have to block this merge.
* Renamed 'cursor.isTimeTagBefore' to 'cursor.isAfterTimeTag' to make it clearer
* Moved time checking to a function * Lint 'Request' blocks * Added time checking for 'request' * Support 'G' time tag linting
* Update unit test
* Update unit test
77fbe2b
to
717ea6e
Compare
Breaking Change: Reworked the Old Format: This change breaks any sequence that relies on the old way to represent |
* Reconfigure ground epoch into a time tag 'G' * Added TimeTag 'G' to autocompletion * Renamed 'cursor.isTimeTagBefore' to 'cursor.isAfterTimeTag' to make it clearer * Added Time Tag 'G' and 'Request' linting support * Moved time checking to a function * Lint 'Request' blocks * Added time checking for 'request' * Support 'G' time tag linting * Added Time Tag 'G' support for seqJson export * Update unit test * Added Time Tag 'G' support for seqJson import * Update unit test * Update unit test to support 'G' time tag
Closes #1368
A new time tag, 'G', to represent the ground epoch in the sequence
Reconfigured Ground Epoch: The ground epoch is now represented as a time tag 'G' to better match with existing time tags
R1 A2020-001T00:00:00 E+00:10:00 C
.Autocompletion support: The 'G' time tag has been added to autocompletion suggestions.
Function refactoring: Time checking logic has been moved to a dedicated function
Linting support: Linting rules have been updated to support the 'G' time tag and ensure correct usage within 'Request' blocks.
SeqJson support: Both export and import functionality for SeqJson include the 'G' time tag, enabling seamless data exchange.
Unit test updates: Unit tests have been modified to cover the new 'G' time tag functionality.
Testing: Make sure you copy-paste this into the editor and export reimport the seqJson for round tripping