Added optional objects to input parameters #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cohansen We probably want to update the core linter since we support this grammar change in the SeqN grammar core. |
I added the object check in the sequence linter, were you talking about somewhere else too? |
|
Wow did not see that :P The only other place is to update the You can use this as a reference Also the |
cohansen
force-pushed
the
feature/sequence-workspaces
branch
from
cfcd13b to
2ddc536
Compare
goetzrrGit
requested changes
Aug 22, 2024
goetzrrGit
approved these changes
Aug 27, 2024
cohansen
force-pushed
the
feature/update-input-params
branch
from
cb11ac4 to
98d6421
Compare
duranb
force-pushed
the
feature/sequence-workspaces
branch
from
2ddc536 to
2576f0f
Compare
cohansen
force-pushed
the
feature/sequence-workspaces
branch
from
2576f0f to
f4d4704
Compare
cohansen
force-pushed
the
feature/update-input-params
branch
from
98d6421 to
4c356a1
Compare
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Rough prototype of workspaces * Added the sequence header back in * More workspace improvements, navigation and persistance working now * Added optional objects to input parameters * Added the parsed input_parameter fields to seqjson * Added linting rules for input parameter objects * Added input param metadata parsing to from-seq-json * Fixed a duplicated style in the SequenceTable * Fixed 2 from-seq-json unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1398.
Adds an optional object to input parameters. Example:
@INPUT_PARAMS testparam { "TYPE": "FLOAT", "RANGE": "1, 2, 135.0..." } asd asd2Thanks for the grammar help @goetzrrGit !