Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly track offsetX in timeline context menu #1435

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Explicitly track offsetX in timeline context menu #1435

merged 3 commits into from
Aug 21, 2024

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Aug 20, 2024 •
edited
Loading

This resolves #1399

To test:

  1. In Firefox specifically, open/create a plan
  2. Open the simulations panel
  3. Hover over the timeline (no activities needed)
  4. Right click anywhere on the timeline
  5. Click "Set Simulation End"
  6. Verify that the simulation end time field now reflects the correct time

The crux of this issue was that (only in Firefox) the X position was being lost between event generation and usage. So this issue was present for any contextmenu event that used cursor positioning after a context menu item was chosen.

Bonus tests:

  1. In Firefox, open/create a plan
  2. Hover over the timeline
  3. Right click anywhere
  4. Choose "Place Guide"
  5. Verify the guide was placed where you right clicked
  6. Right click anywhere again
  7. Hover over "Zoom" and click on one of the zoom choices
  8. Verify that you zoomed in/out around where you right clicked

@duranb duranb requested a review from a team as a code owner August 20, 2024 16:56
@duranb duranb force-pushed the fix/ff-timeline-context-menu-time-callback branch from 6f08549 to 655f269 Compare August 20, 2024 16:57
@duranb duranb merged commit f8e24f7 into develop Aug 21, 2024
5 checks passed
@duranb duranb deleted the fix/ff-timeline-context-menu-time-callback branch August 21, 2024 00:11
duranb added a commit that referenced this pull request Aug 26, 2024
@duranb
Explicitly track offsetX in timeline context menu (#1435)
0af0118 
* fix: explicitly keep track of the timeline context menu position for firefox compatibility
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
@duranb
Explicitly track offsetX in timeline context menu (#1435)
b4f0ae7 
* fix: explicitly keep track of the timeline context menu position for firefox compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronPlave AaronPlave AaronPlave approved these changes

@dandelany dandelany Awaiting requested review from dandelany dandelany is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@joswig joswig Awaiting requested review from joswig joswig is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Right Click > Set Sim Start/End" Broken on Firefox
2 participants
@duranb @AaronPlave