Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull from constraint run table #1429

Merged
merged 12 commits into from
Aug 27, 2024
Merged

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Aug 16, 2024

Resolves #770

This PR introduces a subscription to the constraint_run table to pull the last cached constraint check status for the latest simulation dataset.

Ideally the behavior should be exactly the same for displaying constraint statuses, but the only difference would be that the last constraint status is persisted between reloads.

To test:

  1. Create a constraint export default (): Constraint => Real.Resource("/fruit").lessThan(4)
  2. Create banananation plan
  3. Add a GrowBanana
  4. Associate the constraint created in step 1 to the plan
  5. Simulate
  6. Check constraints
  7. Verify that the constraint status is all green
  8. Refresh and verify that it still shows as all green
  9. Add another GrowBanana
  10. Simulate again
  11. Check constraints again
  12. Verify that a validation error shows
  13. Refresh and verify that it still shows the validation error

@duranb duranb requested a review from a team as a code owner August 16, 2024 20:51
@duranb duranb force-pushed the feature/pull-from-constraint-run-table branch from 4e4bc63 to 9960da4 Compare August 16, 2024 20:56
@duranb duranb force-pushed the feature/pull-from-constraint-run-table branch from 9960da4 to 896b8d3 Compare August 19, 2024 16:35
@duranb duranb force-pushed the feature/pull-from-constraint-run-table branch from 361b832 to 0b0ae7a Compare August 27, 2024 15:49
@duranb duranb merged commit f1507f9 into develop Aug 27, 2024
5 checks passed
@duranb duranb deleted the feature/pull-from-constraint-run-table branch August 27, 2024 18:38
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
* subscribe to `constraint_run` table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI to use new constraint_run table
2 participants