-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull from constraint run table #1429
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duranb
force-pushed
the
feature/pull-from-constraint-run-table
branch
from
August 16, 2024 20:56
4e4bc63
to
9960da4
Compare
duranb
force-pushed
the
feature/pull-from-constraint-run-table
branch
from
August 19, 2024 16:35
9960da4
to
896b8d3
Compare
AaronPlave
reviewed
Aug 27, 2024
AaronPlave
reviewed
Aug 27, 2024
display only relevant runs
fix stale constraint status display when constraints are removed from plan after check
duranb
force-pushed
the
feature/pull-from-constraint-run-table
branch
from
August 27, 2024 15:49
361b832
to
0b0ae7a
Compare
AaronPlave
reviewed
Aug 27, 2024
AaronPlave
approved these changes
Aug 27, 2024
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* subscribe to `constraint_run` table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #770
This PR introduces a subscription to the
constraint_run
table to pull the last cached constraint check status for the latest simulation dataset.Ideally the behavior should be exactly the same for displaying constraint statuses, but the only difference would be that the last constraint status is persisted between reloads.
To test:
export default (): Constraint => Real.Resource("/fruit").lessThan(4)
GrowBanana
GrowBanana