Small plan export improvements #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow is changed to selected or unselected
duranb
added
refactor
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* created CancellableProgressRadial component to make plan export more DRY * fix an issue where progress radial is being reset in plans table if row is changed to selected or unselected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make plan export a little bit DRYer by adding a new component for progress radials that have a cancel icon.
This also fixes a small bug in the Plans table where if a download is in progress in a row, and the row itself is clicked on or another row is selected, the download icon in the table will reset.