-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activity and Resource Browser #1417
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronPlave
had a problem deploying
to
test-workflow
August 6, 2024 18:32 — with
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
August 7, 2024 14:14 — with
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
August 7, 2024 14:16 — with
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
August 7, 2024 20:37 — with
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
August 7, 2024 20:58 — with
GitHub Actions
Failure
AaronPlave
force-pushed
the
feature/activity-and-resource-browser
branch
from
August 8, 2024 17:55
5ab47e3
to
11a1072
Compare
AaronPlave
had a problem deploying
to
test-workflow
August 8, 2024 17:55 — with
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
August 20, 2024 23:47 — with
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
August 21, 2024 03:19 — with
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
August 21, 2024 03:24 — with
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
August 21, 2024 15:41 — with
GitHub Actions
Failure
AaronPlave
force-pushed
the
feature/activity-and-resource-browser
branch
from
August 21, 2024 15:42
264e6b3
to
30fbdcb
Compare
AaronPlave
had a problem deploying
to
test-workflow
August 21, 2024 15:42 — with
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
August 21, 2024 18:43 — with
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
August 21, 2024 18:45 — with
GitHub Actions
Failure
AaronPlave
commented
Aug 21, 2024
AaronPlave
had a problem deploying
to
test-workflow
August 21, 2024 23:22 — with
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
August 22, 2024 00:06 — with
GitHub Actions
Failure
duranb
requested changes
Aug 22, 2024
AaronPlave
had a problem deploying
to
test-workflow
August 22, 2024 20:33 — with
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
August 22, 2024 21:08 — with
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
August 22, 2024 22:37 — with
GitHub Actions
Failure
AaronPlave
force-pushed
the
feature/activity-and-resource-browser
branch
from
August 29, 2024 16:59
c36f7af
to
0d626b2
Compare
AaronPlave
temporarily deployed
to
test-workflow
August 29, 2024 16:59 — with
GitHub Actions
Inactive
duranb
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! lgtm!
Fixes #492 |
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Filter both activity and resource lists by multiple name filters * Include subsystem_tag in activity type subscription * Filter activity list by subsystem * Filter resource list by data type * Display data type and units (if found) in resource list * Add all filtered items as a filter to a new or existing row (user prompted to select a layer within existing row) * Add individual item as a filter to a new row or existing row * Drag items into, above, and below existing rows to add as filters * Create a new row using the "New Row +" button below the last row * Added empty state when no rows exist in timeline * Added a "Delete All" button to relevant sections of the Timeline Editor (rows, axes, guides, layers) * Unified border and shadow styles for Menu, ContextMenu, and DatePicker * Fix y axis label spacing and display bug for x-range layers * Allow y axis ticks to be 0 instead of 1 * Update Chip styling * Include subsystem tag in activity types subscription * Improve tooltip exit animation duration * Improved activity/resource style during drag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the Activity Types panel into the Activity and Resource Types panel and implements the following:
subsystem_tag
in activity type subscriptionTesting:
Activity & Resource Types
panel and verify that the filtering and subsystem/data type dropdowns in activities/resources tabs filter the list below correctlyTODO:
Closes #1416, closes #381