Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity and Resource Browser #1417

Merged
merged 42 commits into from
Aug 29, 2024
Merged

Conversation

AaronPlave
Copy link
Contributor

@AaronPlave AaronPlave commented Aug 6, 2024

Refactors the Activity Types panel into the Activity and Resource Types panel and implements the following:

  • Filter both activity and resource lists by multiple name filters
  • Include subsystem_tag in activity type subscription
  • Filter activity list by subsystem
  • Filter resource list by data type
  • Display data type and units (if found) in resource list
  • Add all filtered items as a filter to a new or existing row (user prompted to select a layer within existing row)
  • Add individual item as a filter to a new row or existing row
  • Drag items into, above, and below existing rows to add as filters
  • Create a new row using the "New Row +" button below the last row
  • Added empty state when no rows exist in timeline
  • Added a "Delete All" button to relevant sections of the Timeline Editor (rows, axes, guides, layers)
  • Unified border and shadow styles for Menu, ContextMenu, and DatePicker
  • Fix y axis label spacing and display bug for x-range layers
  • Allow y axis ticks to be 0 instead of 1
  • Update Chip styling
  • Include subsystem tag in activity types subscription
  • Improve tooltip exit animation duration
  • Improved activity/resource style during drag

Testing:

  • Create some tags and manually associate various activity types to these tags in hasura
  • Open the Activity & Resource Types panel and verify that the filtering and subsystem/data type dropdowns in activities/resources tabs filter the list below correctly
  • Verify that items can be added to a layer or new row using the "Add Filter to Row" button
  • Verify that an individual item can be added to a layer or new row using the (+) button found when hovering over an item
  • Verify that all matching items or an individual item can be added to an existing row or inserted above/below a row
  • Verify that all matching activities or an individual activity can be added to the plan by dragging them onto the canvas portion of the timeline
  • Verify that activities are added into a single layer filter and that resources are added as individual layers with unique colors
  • Verify that clicking the "New Row +" at the bottom of the timeline creates a new blank row
  • Verify that rows, layers, axes, and guides can be bulk deleted from within the timeline editor and that the user is asked to confirm deletion

TODO:

  • Review with team and users
  • Create individual layers when adding multiple resource layers
  • Affordance to indicate drag and drop action on items
  • Auto color for new layers if feasible
  • Prevent activity drag on timeline if user does not have permission to do so
  • Confirmation modal when adding an activity that will not be visible in the row
  • Confirmation modal before "delete all" for all timeline editor sections
  • Fix type issues and refactor in places
  • Tests
  • Update documentation?

Closes #1416, closes #381

image

@AaronPlave AaronPlave force-pushed the feature/activity-and-resource-browser branch from 5ab47e3 to 11a1072 Compare August 8, 2024 17:55
@AaronPlave AaronPlave marked this pull request as ready for review August 21, 2024 15:41
@AaronPlave AaronPlave requested a review from a team as a code owner August 21, 2024 15:41
@AaronPlave AaronPlave force-pushed the feature/activity-and-resource-browser branch from 264e6b3 to 30fbdcb Compare August 21, 2024 15:42
@AaronPlave AaronPlave self-assigned this Aug 21, 2024
@AaronPlave AaronPlave force-pushed the feature/activity-and-resource-browser branch from c36f7af to 0d626b2 Compare August 29, 2024 16:59
@AaronPlave AaronPlave requested a review from duranb August 29, 2024 17:09
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! lgtm!

@AaronPlave AaronPlave merged commit daf4a10 into develop Aug 29, 2024
5 checks passed
@AaronPlave AaronPlave deleted the feature/activity-and-resource-browser branch August 29, 2024 17:17
@joswig
Copy link
Collaborator

joswig commented Sep 3, 2024

Fixes #492

JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
* Filter both activity and resource lists by multiple name filters
* Include subsystem_tag in activity type subscription
* Filter activity list by subsystem
* Filter resource list by data type
* Display data type and units (if found) in resource list
* Add all filtered items as a filter to a new or existing row (user prompted to select a layer within existing row)
* Add individual item as a filter to a new row or existing row
* Drag items into, above, and below existing rows to add as filters
* Create a new row using the "New Row +" button below the last row
* Added empty state when no rows exist in timeline
* Added a "Delete All" button to relevant sections of the Timeline Editor (rows, axes, guides, layers)
* Unified border and shadow styles for Menu, ContextMenu, and DatePicker
* Fix y axis label spacing and display bug for x-range layers
* Allow y axis ticks to be 0 instead of 1
* Update Chip styling
* Include subsystem tag in activity types subscription
* Improve tooltip exit animation duration
* Improved activity/resource style during drag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Improve Browse Panel Consider implementing an "add row" button below last timeline row
4 participants