-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plan Import/Export UI Improvements #1415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, found a few things to discuss/tweak/fix
add export plan logic to plan nav menu add import validation error handling
ce67cd2
to
8ca3d5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
keep download progress shown while downloading from table
@AaronPlave I've pushed a couple more changes to address your ProgressRadial background and visibility comments if you don't mind taking one last look at it |
One last issue - if you are importing a large plan it can take several seconds or longer. We should probably disable the |
* add export plan logic to plans table * add export plan logic to plan nav menu * add import validation error handling * add `version` to plan transfer * add json stream parsing * change plans page to select plan before navigating
resolves #1401
To test import:
To test export: