Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan Import/Export UI Improvements #1415

Merged
merged 25 commits into from
Aug 7, 2024
Merged

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Aug 2, 2024

resolves #1401

To test import:

  1. Create a plan
  2. Export the plan via the plans table icons column in the right most column
  3. Verify that the plan file is downloaded
  4. Click the newly moved "Import" button on the plans page and upload the downloaded plan file from step 3
  5. Verify that the input fields are pre-populated with the correct values from the plan file
  6. Attempt to upload a non .json file
  7. Verify that an error is displayed stating that an incorrect file is selected
  8. Attempt to upload a JSON file with invalid JSON
  9. Verify that an error is displayed

To test export:

  1. Create a plan
  2. Navigate to the plan by first selecting the plan from the table and clicking the "Open plan" button that appears on the left of the page in place of the "Create" button
  3. Once navigated to the plan page, click on the name of the plan in the nav bar
  4. Verify that a new "Export as .json" button is presented
  5. Verify that clicking on the new button results in a plan JSON download

@duranb duranb temporarily deployed to test-workflow August 2, 2024 00:07 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow August 2, 2024 02:32 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow August 2, 2024 03:08 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow August 2, 2024 03:09 — with GitHub Actions Inactive
@duranb duranb marked this pull request as ready for review August 2, 2024 22:13
@duranb duranb requested a review from a team as a code owner August 2, 2024 22:13
@duranb duranb temporarily deployed to test-workflow August 2, 2024 22:13 — with GitHub Actions Inactive
Copy link
Contributor

@AaronPlave AaronPlave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, found a few things to discuss/tweak/fix

duranb added 2 commits August 6, 2024 16:37
add export plan logic to plan nav menu
add import validation error handling
@duranb duranb force-pushed the refactor/plan-import-export branch from ce67cd2 to 8ca3d5d Compare August 6, 2024 23:37
@duranb duranb temporarily deployed to test-workflow August 6, 2024 23:37 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow August 6, 2024 23:52 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow August 7, 2024 17:29 — with GitHub Actions Inactive
Copy link
Contributor

@AaronPlave AaronPlave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

keep download progress shown while downloading from table
@duranb duranb temporarily deployed to test-workflow August 7, 2024 20:36 — with GitHub Actions Inactive
@duranb
Copy link
Collaborator Author

duranb commented Aug 7, 2024

@AaronPlave I've pushed a couple more changes to address your ProgressRadial background and visibility comments if you don't mind taking one last look at it

@AaronPlave
Copy link
Contributor

One last issue - if you are importing a large plan it can take several seconds or longer. We should probably disable the Create from .json button during import, and change it to something like "Creating...".

@duranb duranb temporarily deployed to test-workflow August 7, 2024 21:24 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow August 7, 2024 21:32 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow August 7, 2024 21:38 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow August 7, 2024 21:52 — with GitHub Actions Inactive
@duranb duranb merged commit 0ee4f3c into develop Aug 7, 2024
5 checks passed
@duranb duranb deleted the refactor/plan-import-export branch August 7, 2024 22:36
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
* add export plan logic to plans table
* add export plan logic to plan nav menu
* add import validation error handling
* add `version` to plan transfer
* add json stream parsing
* change plans page to select plan before navigating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plan Import/Export Improvements
3 participants