[Bug] Boolean args not supported for arguments #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated precedence so the grammar checks for booleans before identifiers to generate the tree correctly.
goetzrrGit
added
sequencing
duranb
reviewed
Jul 30, 2024
duranb
requested changes
Jul 30, 2024
There was a problem hiding this comment.
If I add the GENERIC command dictionary from /e2e-tests/data/command-dictionary.xml, create a parcel using it, and then create a sequence with C FSW_CMD_0 "ON" false 1, I'm still seeing the message in the "Selected Command" panel for the boolean_arg_0 as "Unexpected value for definition".
Also, I don't see any linting errors regardless of whether I pass false, FALSE, "FALSE", or "false". Should I be seeing any?
|
@duranb should be good now. I added a boolean argument to the command panel and updated the linter |
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Added boolean to arg grammar * Updated precedence so the grammar checks for booleans before identifiers to generate the tree correctly. * Import boolean args correctly to seqN * Export boolean arg in seqJSON correctly * Hook up boolean arg to Command Panel * Add boolean check to linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1395
Previously missing boolean argument support has been added to args, along with corresponding updates to seqJSON and seqN import/export functions. I have updated the e2e test as well