Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Event Procedural Scheduling Documentation #193

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

pranav-super
Copy link
Contributor

@pranav-super pranav-super commented Oct 24, 2024

This pull-request adds documentation for the external events-based procedural scheduling feature being currently worked into Aerie (#1585).

We might want to add more examples of scheduling procedures directly to aerie-docs, but where we can specify that is currently unclear as there is only one currently in the docs.

@JoelCourtney JoelCourtney force-pushed the feat/proc-sched-external-events branch from d042484 to dc0dbe8 Compare October 31, 2024 23:53
Copy link
Collaborator

@dandelany dandelany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I pushed a few small changes directly to this branch, namely:

  • Removed "scheduling" from the list of "coming soon" features on the general External Events docs page
  • Added a new section to ^this page to mention that it can be done now and link to the relevant scheduling pages
  • a few new cross links between pages
  • a few extra code comments in examples

@dandelany dandelany merged commit b21d528 into develop Nov 6, 2024
1 check passed
@dandelany dandelany deleted the feat/proc-sched-external-events branch November 6, 2024 00:42
@dandelany
Copy link
Collaborator

Merged - thanks @pranav-super and @JoelCourtney for writing this up - the new Examples page is especially useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants