Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added max-width to legend to prevent long text from filling screen #394

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Added max-width to legend to prevent long text from filling screen #394

merged 2 commits into from
Jul 13, 2023

Conversation

jtroberts
Copy link
Member

Purpose

  • I have legend values with long descriptive text that are expanding the legend to fill nearly the entire screen.

Proposed Changes

  • Added a max-width property to limit the expansion of text.

Issues

Testing

  • Tested different legends with various css values to find a good compromise.

@jtroberts jtroberts requested review from ac-61 and tariqksoliman July 13, 2023 00:06
tariqksoliman
tariqksoliman approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@tariqksoliman tariqksoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It might be worthwhile to use text-overflow: ellipsis; and a title attribute too.

@jtroberts
Copy link
Member Author

The ellipsis with title looks a lot better than the scrollbar. Thanks!

@jtroberts jtroberts merged commit eb10fc4 into development Jul 13, 2023
@jtroberts jtroberts deleted the jr-maxwidth-legend branch July 13, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tariqksoliman tariqksoliman tariqksoliman approved these changes

@ac-61 ac-61 Awaiting requested review from ac-61

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtroberts @tariqksoliman