Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an option to the LegendTool to automatically display on start #393

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Added an option to the LegendTool to automatically display on start #393

merged 2 commits into from
Jul 12, 2023

Conversation

jtroberts
Copy link
Member

Purpose

  • Some projects like having the legend visible and expanded when the map loads.

Proposed Changes

  • This PR adds an option to the LegendTool to automatically display the legend on start.

Issues

Testing

  • Tested with LegendTool turned on/off.
  • Tested with displayOnStart set to true/false/null/etc.
  • Legend behaves as expected.

@jtroberts jtroberts requested review from ac-61 and tariqksoliman July 12, 2023 19:02
tariqksoliman
tariqksoliman approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@tariqksoliman tariqksoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and thank you!

@jtroberts jtroberts merged commit e608671 into development Jul 12, 2023
@jtroberts jtroberts deleted the jr-displayonstart-legend branch July 13, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tariqksoliman tariqksoliman tariqksoliman approved these changes

@ac-61 ac-61 Awaiting requested review from ac-61

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtroberts @tariqksoliman