Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NOTICE-binary file #128

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

SemyonSinchenko
Copy link
Collaborator

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added or modified a feature, documentation in docs is updated

Description of changes

We need to follow licenses of our dependencies little more strictly. I'm not 100% sure how to do it, but I think adding NOTICE-binary is a good first step.

Close #116

 On branch 116-notice-file
 Changes to be committed:
	new file:   NOTICE-binary.md
@SemyonSinchenko SemyonSinchenko requested a review from fpgmaas July 18, 2024 08:57
@SemyonSinchenko
Copy link
Collaborator Author

@fpgmaas Do you have an idea, how can we include this file into an output python package? Based on my knowledge, we must distribute it with the chispa itself.

 On branch 116-notice-file
 Changes to be committed:
	modified:   NOTICE-binary.md
@fpgmaas
Copy link
Collaborator

fpgmaas commented Jul 18, 2024

@fpgmaas Do you have an idea, how can we include this file into an output python package? Based on my knowledge, we must distribute it with the chispa itself.

@SemyonSinchenko I think we can use Poetry's include, I did something similar here

@fpgmaas
Copy link
Collaborator

fpgmaas commented Jul 18, 2024

@SemyonSinchenko I don't think we need this though, right? We don't distribute a copy of these packages ourselves. We just mention that our package needs these packages. These are then installed by the user from PyPI, and that includes the license. Do you know any other big OS projects that do this?

@SemyonSinchenko
Copy link
Collaborator Author

@SemyonSinchenko I don't think we need this though, right? We don't distribute a copy of these packages ourselves. We just mention that our package needs these packages. These are then installed by the user from PyPI, and that includes the license. Do you know any other big OS projects that do this?

I do not know to be honest... You are right, let's leave it as is, just a NOTICE file.

@SemyonSinchenko SemyonSinchenko merged commit 67a6079 into MrPowers:main Jul 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Create NOTICE file
2 participants