Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable ruff rules RUF and UP #126

Merged
merged 1 commit into from
Jul 17, 2024
Merged

chore: enable ruff rules RUF and UP #126

merged 1 commit into from
Jul 17, 2024

Conversation

fpgmaas
Copy link
Collaborator

@fpgmaas fpgmaas commented Jul 17, 2024 •
edited
Loading

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added or modified a feature, documentation in docs is updated

Description of changes

Enable ruff rulesets RUF and UP. Needs to be rebased after #125 is merged.

@fpgmaas fpgmaas requested a review from SemyonSinchenko July 17, 2024 15:34
SemyonSinchenko
SemyonSinchenko approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge it after resolving conflicts

@fpgmaas fpgmaas force-pushed the ruff/enable-ruf-and-up branch from a014fbc to 4e73e5f Compare July 17, 2024 15:55
@fpgmaas fpgmaas merged commit d54bc96 into MrPowers:main Jul 17, 2024
7 checks passed
@fpgmaas fpgmaas deleted the ruff/enable-ruf-and-up branch July 17, 2024 15:59
fpgmaas added a commit to fpgmaas/chispa that referenced this pull request Jul 17, 2024
@fpgmaas
enable RUF and UP (MrPowers#126)
30b41f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SemyonSinchenko SemyonSinchenko SemyonSinchenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpgmaas @SemyonSinchenko