Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Window snapping won't work in secondary display screen #350

Closed
2 tasks done
ClarkGeng996 opened this issue May 11, 2024 · 7 comments · Fixed by #360 or #361
Closed
2 tasks done

🐛 Window snapping won't work in secondary display screen #350

ClarkGeng996 opened this issue May 11, 2024 · 7 comments · Fixed by #360 or #361
Assignees
Labels

Comments

@ClarkGeng996
Copy link

Bug Description

  1. My secondary screen is above my macbook internal screen. Like the attachment.
    13891715412652_ pic
  2. In internal screen, window snapping works well.
  3. If you snap the windows from internal screen to external screen edge without interruption, it also works well.
  4. SO the bad case is if you sanp the windows already in external screen to its edge, it won't works.

Steps To Reproduce

Sanp the windows already in external screen to its edge, the funtion of window snapping won't works.

Expected Behavior

Obviously window snapping should work well in any displays.

Actual Behavior

SO the bad case is if you sanp the windows already in external screen to its edge, it won't works.

Screenshots

No response

MacOS Version

Sonoma 14.4.1 (23E224)

Loop Version

Version 1.0.0-beta.15 (817)

Additional Context

Thanks for your hardworking to building this brilliant software.

Final Checks

  • My issue title is descriptive
  • This is a single bug (multiple bugs should be reported individually)
@MrKai77
Copy link
Owner

MrKai77 commented May 11, 2024

Thanks for the report!
However, I am unable to reproduce that bug. Would you be able to send a quick screen recording of this bug if possible?

@MrKai77 MrKai77 changed the title 🐛 [Window snapping won't work in secondary display screen ] 🐛 Window snapping won't work in secondary display screen May 11, 2024
@ClarkGeng996
Copy link
Author

No Problem.
Please see the attached file.

1393_1715652569.mp4

@MrKai77
Copy link
Owner

MrKai77 commented May 21, 2024

Alright, somehow I was just able to reproduce this issue! I will definitely try and fix this by the next update :)

@MrKai77 MrKai77 self-assigned this May 21, 2024
@ClarkGeng996
Copy link
Author

So great news! Thanks for your hard working! Looking forward to next update and checking update everyday.
Loop is a REAL macOS style window management App.
Excited.

@MrKai77
Copy link
Owner

MrKai77 commented May 23, 2024

Try this :)
Loop.zip

Turns out that Loop wasn't correctly calculating mouse coordinates on external screens when window snapping :P

@ClarkGeng996
Copy link
Author

Hi Mrkai77, thanks for your new version.
BTW. It seems you changed trigger condition for window snapping?Only if I drop window to the very top of my screen(just same as magnet) instead of at the beginning of touching menu bar.
I think the original method is better for user.

@MrKai77
Copy link
Owner

MrKai77 commented May 27, 2024

That change was made by #212. I will look into it again, since I do find that it does become a little hard to snap windows to the top when two screens are stacked vertically too :)

@MrKai77 MrKai77 reopened this May 27, 2024
MrKai77 added a commit that referenced this issue May 30, 2024
@MrKai77 MrKai77 linked a pull request May 30, 2024 that will close this issue
@MrKai77 MrKai77 changed the title 🐛 Window snapping won't work in secondary display screen 🐛 Window snapping won't work in secondary display screen Jun 5, 2024
@MrKai77 MrKai77 closed this as completed Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants