Don't auto-cycle for changes #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So in other words this is letting tasks that are running run to "completion" instead of stopping or cycling? |
tysmith
approved these changes
Aug 30, 2023
jschwartzentruber
force-pushed
the
no-auto-cycle
branch
from
a7cad36 to
37461c6
Compare
As far as I know, yes. We may get killed by Taskcluster if things change under us, but have no control over that. |
This means created/modified pools will not be run automatically, nor will removed/disabled pool tasks be killed. To cycle a pool, either trigger its hook manually, or wait until the next scheduled cycle.
jschwartzentruber
force-pushed
the
no-auto-cycle
branch
from
37461c6 to
fd2ded7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means created/modified pools will not be run automatically, nor will removed/disabled pool tasks be killed.
To cycle a pool, either trigger its hook manually, or wait until the next scheduled cycle.